fix: workaround disappearing text on spellcheck suggestion #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
commented
Sep 18, 2023
| if (child.unwrap) child.unwrap(); | ||
| }); | ||
|
|
||
| this.remove(); |
There was a problem hiding this comment.
If you comment out this line, you'll notice that the DOM node is originally a <font> element, inserted by the browser spellcheck functionality exactly as described in slab/quill#2096 (comment).
vursen
approved these changes
Sep 19, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
web-padawan
added a commit
that referenced
this pull request
Sep 19, 2023
…6511) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Sep 21, 2023
…6512) Co-authored-by: Serhii Kulykov <[email protected]>
ghost
pushed a commit
to dethell/web-components
that referenced
this pull request
Sep 26, 2023
|
This ticket/PR has been released with Vaadin 24.2.0.beta1 and is also targeting the upcoming stable 24.2.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6369
Added a workaround from slab/quill#2096 (comment)
No tests as the issue can be only tested manually 😕
Type of change