-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: propagate autocapitalize attribute in Chrome #5175
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi @web-padawan , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually? |
Hi @web-padawan , this commit cannot be picked to 23.2 by this bot, can you take a look and pick it manually? |
Description
Fixes vaadin/flow-components#4452
Added
reflectToAttribute: true
to fix a Chrome specific issue where settingautocapitalize
attribute does not set corresponding property and it remainsundefined
so the delegation observer fails to set it on the<input>
.This only affects
autocapitalize
- two other properties work fine, so I didn't addreflectToAttribute
there.While I don't really like inconsistency, this is the cleanest fix that I was able to come up with 🤷♂️
See vaadin/flow-components#4452 (comment)
Type of change