Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate autocapitalize attribute in Chrome #5175

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

web-padawan
Copy link
Member

Description

Fixes vaadin/flow-components#4452

Added reflectToAttribute: true to fix a Chrome specific issue where setting autocapitalize attribute does not set corresponding property and it remains undefined so the delegation observer fails to set it on the <input>.

This only affects autocapitalize - two other properties work fine, so I didn't add reflectToAttribute there.
While I don't really like inconsistency, this is the cleanest fix that I was able to come up with 🤷‍♂️

See vaadin/flow-components#4452 (comment)

Type of change

  • Bugfix

@sonarcloud
Copy link

sonarcloud bot commented Dec 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 621c1e8 into master Dec 28, 2022
@web-padawan web-padawan deleted the fix/autocapitalize-attr branch December 28, 2022 11:28
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 621c1e8
error: could not apply 621c1e8... fix: propagate autocapitalize attribute in Chrome (#5175)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @web-padawan , this commit cannot be picked to 23.2 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 621c1e8
error: could not apply 621c1e8... fix: propagate autocapitalize attribute in Chrome (#5175)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocapitalize does not work in TextField
3 participants