Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable cancelSyntheticClickEvents globally #3510

Merged
merged 3 commits into from
Mar 3, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Mar 2, 2022

Description

The PR disables the cancelSyntheticClickEvents Polymer setting through ElementMixin.

This setting determines whether the legacy Polymer gestures module should globally listen for click events on the page and cancel them if they are considered synthetic. Normally, the legacy gestures module is not supposed to be imported anywhere in the web components and component-base/src/gestures.js should be used instead which doesn't have that logic. However, if you import an iron component e.g. iron-icon or iron-list, it will implicitly cause the legacy gestures module to import.

This setting has to be disabled because otherwise, it affects vaadin-button components, preventing them from triggering actions on click. It occurs when (a) both a button and an iron component are used on the same page (b) iOS VoiceOver is used as a screen assistant.

Since the canceling synthetic clicks logic was introduced mainly for old browsers, it is no longer reasonable to keep it enabled.

Fixes #3364 #3367

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit f5da160 into master Mar 3, 2022
@web-padawan web-padawan deleted the fix/disable-cancel-synthetic-click-events branch March 3, 2022 07:51
web-padawan pushed a commit that referenced this pull request Mar 3, 2022
web-padawan added a commit that referenced this pull request Mar 7, 2022
web-padawan added a commit that referenced this pull request Mar 7, 2022
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[select] Dropdown cannot be activated
5 participants