-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable cancelSyntheticClickEvents globally #3510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Mar 2, 2022
tomivirkki
reviewed
Mar 2, 2022
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
tomivirkki
approved these changes
Mar 3, 2022
web-padawan
approved these changes
Mar 3, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
web-padawan
pushed a commit
that referenced
this pull request
Mar 3, 2022
Co-authored-by: Sergey Vinogradov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Mar 7, 2022
web-padawan
added a commit
that referenced
this pull request
Mar 7, 2022
This ticket/PR has been released with Vaadin 23.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR disables the
cancelSyntheticClickEvents
Polymer setting throughElementMixin
.This setting determines whether the legacy Polymer gestures module should globally listen for click events on the page and cancel them if they are considered synthetic. Normally, the legacy gestures module is not supposed to be imported anywhere in the web components and
component-base/src/gestures.js
should be used instead which doesn't have that logic. However, if you import an iron component e.g. iron-icon or iron-list, it will implicitly cause the legacy gestures module to import.This setting has to be disabled because otherwise, it affects
vaadin-button
components, preventing them from triggering actions on click. It occurs when (a) both a button and an iron component are used on the same page (b) iOS VoiceOver is used as a screen assistant.Since the canceling synthetic clicks logic was introduced mainly for old browsers, it is no longer reasonable to keep it enabled.
Fixes #3364 #3367
Type of change
Checklist