fix: import vaadin-iconset in main entrypoint #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
approved these changes
Mar 1, 2022
|
Related to #3367 |
10 tasks
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
web-padawan
added a commit
that referenced
this pull request
Mar 1, 2022
Co-authored-by: Serhii Kulykov <[email protected]>
|
This ticket/PR has been released with Vaadin 23.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we discovered,
all-imports.jsstill includes the imports foriron-iconthat is considered to be deprecated.We updated
vaadin-iconsin #2853 for Vaadin 22, but forgot to do the same forvaadin-lumo-styles.This PR changes the main entrypoint so that users would not get legacy icon implementation when using it.
Note, the main entrypoint is used in Flow application theme plugin when processing
"lumoImports".Type of change