fix: do not remove menu item component theme #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/menu-component-theme
branch
from
2978a3f
to
abf95e0
Compare
web-padawan
commented
Feb 17, 2022
| }, | ||
| { text: 'foo-1' } | ||
| ]; | ||
| open(); | ||
| await nextFrame(); | ||
| await nextRender(); |
There was a problem hiding this comment.
Changed to use nextRender() which seems to be needed to make all the nested menus rendered properly when debugging (otherwise the elements are in the DOM but not visible).
web-padawan
commented
Feb 17, 2022
| @@ -567,7 +579,7 @@ describe('items', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should override the component theme with the item theme', async () => { | |||
| it('should override the host theme with the item theme', async () => { | |||
There was a problem hiding this comment.
Changed to use host which better describes the actual behavior.
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Feb 17, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 17, 2022
web-padawan
added a commit
that referenced
this pull request
Feb 17, 2022
Co-authored-by: Serhii Kulykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
themefeature (#2401) introduced a regression: removal of thethemeattribute set on theitem.component.This PR checks if the component already has a theme to make sure it's preserved.
Fixes vaadin/flow-components#2559
Type of change