fix: prevent grid body from expanding on dragover #3263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/flow-components#1610
The core of the fix is an additional CSS rule that forces the drag-over indicator to be smaller when dragging below the last row (with
allRowsVisible
on). This essentially prevents the container from expanding in height and becoming scrollable.The CSS selector required adding a new state attribute (
last
) for the last non-hidden body row element.