refactor: add missing SlotController logic and tests #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Dec 13, 2021
web-padawan
force-pushed
the
refactor/slot-controller-tests
branch
from
e225228
to
45f9375
Compare
web-padawan
force-pushed
the
refactor/slot-controller-tests
branch
from
45f9375
to
7c1952b
Compare
tomivirkki
reviewed
Dec 13, 2021
tomivirkki
approved these changes
Dec 13, 2021
web-padawan
force-pushed
the
refactor/slot-controller-tests
branch
from
67570ba
to
58a9af9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
approved these changes
Dec 13, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 13, 2021
web-padawan
added a commit
that referenced
this pull request
Dec 13, 2021
Co-authored-by: Serhii Kulykov <[email protected]>
|
This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out we missed to add tests to
SlotControllerwhen implementing it 🙈So it was only tested through
InputControllerandTextAreaController.This PR adds missing tests after moving to
component-basepackage.Also, implemented previously missing logic to support default slot.
Depends on #3178
Type of change