feat: add focus-ring attribute to vaadin-upload-file #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
Dec 7, 2021
web-padawan
force-pushed
the
feat/upload-file-focus
branch
from
b31603f
to
81f8131
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Dec 7, 2021
36 tasks
|
This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FocusMixinand changed to usefocus-ringstyles, similarly as we did forvaadin-scroller,focusinandfocusoutlisteners to hanle focusing buttons in Shadow DOM.Fixes #3117
Type of change