refactor!: make vaadin-crud-edit extend vaadin-button #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
approved these changes
Dec 7, 2021
web-padawan
force-pushed
the
refactor/crud-edit-button
branch
from
71140b0
to
bdf0a31
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
36 tasks
|
This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vaadin-crud-editcomponent to extendButtoninstead of just usingrole="button"🙈<div part="icon">to align withvaadin-drawer-togglethat also extendsvaadin-button.vaadin-buttonstyles to ensure the visual appearance is the same.Fixes #1238
Type of change