Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use relative position for grid rows #3016

Merged
merged 3 commits into from
Nov 11, 2021

Conversation

tomivirkki
Copy link
Member

Fixes a bug in the row focus styles. In case you have multiple header (or footer) rows, the row focus highlight appears as if it covers the full header instead of a single row.

Screenshot 2021-11-09 at 17 07 43

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we come up with some kind of a visual test for this? Ideally it would use sendKeys to test that the actual problem on the attached screenshot is fixed.

@tomivirkki
Copy link
Member Author

Can we come up with some kind of a visual test for this? Ideally it would use sendKeys to test that the actual problem on the attached screenshot is fixed.

Added the tests.

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 850ff13 into master Nov 11, 2021
@web-padawan web-padawan deleted the fix-header-row-focus-styles branch November 11, 2021 10:42
web-padawan pushed a commit that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants