Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix time-picker step property API docs [skip ci] #301

Merged
merged 1 commit into from
May 3, 2021

Conversation

vlukashov
Copy link

@vlukashov vlukashov commented May 3, 2021

Description

Clarifies the description of the step property in vaadin-date-time-picker and vaadin-time-picker components to make it clear that it's a number of seconds between steps, not the number of steps in a day.

Fixes #254

Related PR to update the docs: vaadin/docs#424

Type of change

  • Bugfix
  • Feature

@web-padawan web-padawan changed the title fix: step property API docs for time picker [skip ci] docs: step property API docs for time picker [skip ci] May 3, 2021
Clarifies the description of the `step` property in vaadin-date-time-picker and vaadin-time-picker components to make it clear that it's a number of seconds between steps, not the number of steps in a day.

Related #254
@web-padawan web-padawan force-pushed the vl/fix/254-date-time-picker-step-docs branch from 2ab932e to 33b9f11 Compare May 3, 2021 06:53
@web-padawan web-padawan changed the title docs: step property API docs for time picker [skip ci] docs: fix time-picker step property API docs [skip ci] May 3, 2021
@web-padawan web-padawan merged commit a9dfd62 into master May 3, 2021
@web-padawan web-padawan deleted the vl/fix/254-date-time-picker-step-docs branch May 3, 2021 06:54
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

vaadin-bot pushed a commit that referenced this pull request May 3, 2021
Clarifies the description of the `step` property in vaadin-date-time-picker and vaadin-time-picker components to make it clear that it's a number of seconds between steps, not the number of steps in a day.

Related #254
web-padawan pushed a commit that referenced this pull request May 3, 2021
Clarifies the description of the `step` property in vaadin-date-time-picker and vaadin-time-picker components to make it clear that it's a number of seconds between steps, not the number of steps in a day.

Related #254

Co-authored-by: Viktor Lukashov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a date time picker with second resolution does not work
3 participants