Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a better workaround for iron-list scrollToIndex issue #2922

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Oct 25, 2021

A change in a previous PR affected how the iron-list issue mentioned here manifests. Needed to improve the workaround to mitigate the issue with the changed setup. The regression was caught by a GridPro Flow-component integration test.

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 19b1d54 into master Oct 25, 2021
@web-padawan web-padawan deleted the scroll-to-index-workaround branch October 25, 2021 16:56
@vaadin-bot
Copy link
Collaborator

Hi @tomivirkki , this commit cannot be picked to 21.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 19b1d54
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 3756 and retry the command.
error: could not apply 19b1d54... fix: workaround scrollToIndex issue (#2922)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta1 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants