feat: allow easy customizing of required indicator's color

[knoobie]

Description

Allows easy customization of the default required indicator's color to allow for common use cases like red colored required indicator without overwriting the part=required-indicator for every component.

Type of change

• Bugfix
• Feature

Checklist

• I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
• I have added a description following the guideline.
• The issue is created in the corresponding repository and I have referenced it.
• I have added tests to ensure my change is effective and works as intended.
• New and existing tests are passing locally with my change.
• I have performed self-review and corrected misspellings.

Additional for Feature type of change

• Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

--> Half / Half .. it was dicussed with Jouni in the ticket; but there is not AC created.

[knoobie]

@web-padawan Sorry, but I'm kinda lost how to create a test for this change.. the whole JS is a little bit to magical for me.. I looked for a test that checks that the other variable (--lumo-required-field-indicator) works but could not find one to base my test on it.

[web-padawan]

@knoobie Thanks for the PR. No worries, we can help with adding tests for this on Monday.
We don't have visual tests for Lumo package yet, so I will ask Jouni about how to proceed.

[jouni]

I don't remember any more if we’ve discussed this previously, but I feel we could/should drop the opacity property from the indicator, and let it be shown for both non-filled and filled fields.

[web-padawan]

Yes we discussed it: #85 but let's make sure we land that in a separate PR, it will require adding some visual tests.

[knoobie]

Updated PR and removed the opacity change

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[web-padawan]

The PR looks good to me. I'm going to merge it as is, then we can think of adding visual tests to Lumo separately.

[vaadin-bot]

This ticket/PR has been released with platform 22.0.0.