fix: use lumo iconset with vaadin-icon #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Sep 8, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
web-padawan
pushed a commit
that referenced
this pull request
Sep 8, 2021
web-padawan
pushed a commit
that referenced
this pull request
Sep 8, 2021
Co-authored-by: Sascha Ißbrücker <[email protected]>
|
This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently it is not possible to use the Lumo iconset with the
vaadin-iconcomponent that was introduced in 21:The issue is that the Lumo iconset is currently not loaded as a
vaadin-iconset, which means thatvaadin-iconcan not find the icon collection.To fix this I included the
vaadin-iconset.jsof the Lumo theme into the all imports file (viaicons.js). That also means that both, theiron-iconsetandvaadin-iconsetversions of the Lumo iconset will be loaded, increasing the payload transmitted to the browser. As I understand it that is intended to allow backwards compatibility withiron-iconin the meantime.Also not 100% in which versions this fix should land. For now I targeted master and 21.
Type of change