refactor: drop use of include option with registerStyles #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
include-deprecation-warning
branch
2 times, most recently
from
96749a4
to
828b80d
Compare
tomivirkki
force-pushed
the
include-deprecation-warning
branch
from
828b80d
to
425b19a
Compare
web-padawan
reviewed
Sep 6, 2021
packages/password-field/theme/lumo/vaadin-password-field-styles.js
Outdated
Show resolved
Hide resolved
| } | ||
| `; | ||
|
|
||
| registerStyles('vaadin-combo-box-overlay', [overlay, menuOverlayCore, comboBoxOverlay], { |
There was a problem hiding this comment.
I was wondering if this PR addresses #1697 too? Or is that still an issue with new includes?
There was a problem hiding this comment.
Seems that this PR alone doesn't solve the issue. Maybe if we added some extra logic to registerStyles to eliminate duplicate CSSResults etc
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Sep 6, 2021
|
This ticket/PR has been released with platform 22.0.0.alpha3 and is also targeting the upcoming stable 22.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a deprecation warning for the
{ include }option inregisterStylesAPI.Also drops internal use of
{ include }in favor of using ES modules for style sharing.It's really recommended to use the "Hide whitespace changes" option in the "Files changed" view of this PR.