-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SlotStylesMixin for injecting styles #2445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
added
a11y
Accessibility issue
a11y phase 1
First batch of accessibility fixes
labels
Sep 3, 2021
web-padawan
force-pushed
the
feat/slot-styles-mixin
branch
2 times, most recently
from
September 3, 2021 09:30
8b32e6c
to
86975f5
Compare
tomivirkki
reviewed
Sep 3, 2021
web-padawan
force-pushed
the
feat/slot-styles-mixin
branch
from
September 3, 2021 20:08
86975f5
to
0a3f0b7
Compare
tomivirkki
reviewed
Sep 6, 2021
tomivirkki
approved these changes
Sep 6, 2021
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
tomivirkki
approved these changes
Sep 6, 2021
This ticket/PR has been released with platform 22.0.0.alpha3 and is also targeting the upcoming stable 22.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a11y phase 1
First batch of accessibility fixes
a11y
Accessibility issue
prerelease version for platform 22.0.0
Released with Platform 22.0.0.alpha3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was hoping to avoid this but looks like this is the way to go. Based on the prototype.
There will be a follow-up PR which uses this mixin to add styles to
vaadin-number-field
e.g. like this:Note, this could be used by some components like
vaadin-tab
to cover cases like the one mentioned in #872Part of #2436
Type of change