New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accept custom tabindex attribute #2443

Merged

web-padawan merged 2 commits into master from fix/tabindex-mixin/custom-value

Sep 2, 2021

Contributor

vursen commented Sep 2, 2021 •

edited

Loading

Description

This PR fixes a regression that appeared in Flow ITs after we released the new @vaadin/button package:

When setting a custom tabindex attribute before the initialization of the button, the attribute gets overridden with the default tabindex value (0).

Fixes #2442

Type of change

Bugfix

Checklist

I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
I have added a description following the guideline.
The issue is created in the corresponding repository and I have referenced it.
I have added tests to ensure my change is effective and works as intended.
New and existing tests are passing locally with my change.
I have performed self-review and corrected misspellings.


          fix: accept custom tabindex attribute

38ad222

vursen force-pushed the fix/tabindex-mixin/custom-value branch from 60f1781 to 38ad222 Compare

September 2, 2021 14:52

vursen requested a review from web-padawan

September 2, 2021 14:54


          test: add more tests

878f636

vursen force-pushed the fix/tabindex-mixin/custom-value branch from 18006d5 to 878f636 Compare

September 2, 2021 15:01

sonarcloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

web-padawan approved these changes

View reviewed changes

Member

web-padawan left a comment

Confirmed that ButtonIT.clickOnTabIndexButtons_textIsDisplayed passes locally with this fix.

web-padawan merged commit 263e2df into master

web-padawan deleted the fix/tabindex-mixin/custom-value branch

September 2, 2021 15:10

Collaborator

vaadin-bot commented Sep 8, 2021

This ticket/PR has been released with platform 22.0.0.alpha3 and is also targeting the upcoming stable 22.0.0 version.

vaadin-bot added prerelease version for platform 22.0.0 Released with Platform 22.0.0.alpha3 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prerelease version for platform 22.0.0 Released with Platform 22.0.0.alpha3