Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve visual tests setup, update screenshots #244

Merged
merged 4 commits into from
Apr 21, 2021
Merged

test: improve visual tests setup, update screenshots #244

merged 4 commits into from
Apr 21, 2021

Conversation

web-padawan
Copy link
Member

Description

This is a follow-up from #239 that aims to make visual tests build green.

  1. Updated reference screenshots after downgrading Chrome version to 88
  2. Fixed the script to check if visual folder exists when running all visual tests
  3. Fixed the script to run visual tests when reference screenshots are updated

Type of change

  • Internal change

vursen
vursen reviewed Apr 21, 2021
View reviewed changes
wtr-utils.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit ae707fd into master Apr 21, 2021
@web-padawan web-padawan deleted the test/fix-screenshots branch April 21, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @sissbruecker @vursen