Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: re-export new checkbox packages #2419

Merged
merged 1 commit into from
Aug 31, 2021
Merged

refactor!: re-export new checkbox packages #2419

merged 1 commit into from
Aug 31, 2021

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Aug 30, 2021 •
edited
Loading

Description

This PR makes @vaadin/vaadin-checkbox re-export @vaadin/checkbox and @vaadin/checkbox-group.

The PR follows the instruction given in #1992 (comment).

  • 2. Create a PR where re-create the old package for backward compatibility.

Part of #1992.

Type of change

  • Breaking change

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen changed the title Feat/move checkbox 2 refactor: re-create vaadin-checkbox for backward compatibility Aug 30, 2021
@vursen vursen changed the title refactor: re-create vaadin-checkbox for backward compatibility refactor!: re-create vaadin-checkbox for backward compatibility Aug 30, 2021
@vursen vursen changed the title refactor!: re-create vaadin-checkbox for backward compatibility refactor!: re-export new checkbox package Aug 30, 2021
@vursen vursen changed the title refactor!: re-export new checkbox package refactor!: re-export new checkbox and checkbox-group packages Aug 30, 2021
@vursen vursen changed the title refactor!: re-export new checkbox and checkbox-group packages refactor!: re-export new checkboxpackages Aug 30, 2021
@vursen vursen changed the title refactor!: re-export new checkboxpackages refactor!: re-export new checkbox packages Aug 30, 2021
@vursen vursen force-pushed the feat/move-checkbox-2 branch 2 times, most recently from caad866 to 77c48e2 Compare August 31, 2021 09:18
@web-padawan web-padawan merged commit 9ce4136 into master Aug 31, 2021
@web-padawan web-padawan deleted the feat/move-checkbox-2 branch August 31, 2021 09:22
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @web-padawan