New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: revert button container #2402

Merged

web-padawan merged 1 commit into master from refactor/revert-button-container

Aug 27, 2021

Contributor

vursen commented Aug 27, 2021 •

edited

Loading

Description

Decided not to introduce the [part=button] part and revert the .vaadin-button-container class in the new @vaadin/button package.

Part of #2224

Type of change

Internal change

Checklist

I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
I have added a description following the guideline.
The issue is created in the corresponding repository and I have referenced it.
I have added tests to ensure my change is effective and works as intended.
New and existing tests are passing locally with my change.
I have performed self-review and corrected misspellings.

Additional for `Feature` type of change

Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.


          refactor: revert button container

4558a96

vursen requested a review from web-padawan

August 27, 2021 07:56

web-padawan approved these changes

View reviewed changes

web-padawan merged commit 087dc7f into master

web-padawan deleted the refactor/revert-button-container branch

August 27, 2021 07:58

sonarcloud bot commented Aug 27, 2021

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet