-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add i18n property to menu bar #2384
Conversation
Co-authored-by: Tomi Virkki <[email protected]>
I'm assuming the 0.01% screenshot difference is not caused by this task. As for the failed tests, sorry for that, didn't realize I hadn't run on Firefox. It seems like it can be fixed by changing |
Yes, this is a known problem specific to this component.
Thanks, fixed. |
The PR is green and IMO it is ready to go 👍 But it needs another review as I can't approve my own PR. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This ticket/PR has been released with platform 22.0.0.alpha2 and is also targeting the upcoming stable 22.0.0 version. |
Description
Same as #2381 but from the branch in this repo.
To be accessible, the menu bar overflow button needs the aria-label attribute to be set.
The attribute should be localizable. As such, this adds an i18n object to the menu bar,
and uses it to set the aria-label of the overflow button.
Connected to #87
Type of change
Checklist
Additional for
Feature
type of change