Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add i18n property to menu bar #2384

Merged
merged 4 commits into from
Aug 24, 2021
Merged

feat: add i18n property to menu bar #2384

merged 4 commits into from
Aug 24, 2021

Conversation

web-padawan
Copy link
Member

Description

Same as #2381 but from the branch in this repo.

To be accessible, the menu bar overflow button needs the aria-label attribute to be set.
The attribute should be localizable. As such, this adds an i18n object to the menu bar,
and uses it to set the aria-label of the overflow button.

Connected to #87

Type of change

  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@web-padawan web-padawan self-assigned this Aug 24, 2021
@web-padawan web-padawan added a11y Accessibility issue a11y phase 1 First batch of accessibility fixes labels Aug 24, 2021
@web-padawan web-padawan mentioned this pull request Aug 24, 2021
8 tasks
@eriklumme
Copy link

I'm assuming the 0.01% screenshot difference is not caused by this task.

As for the failed tests, sorry for that, didn't realize I hadn't run on Firefox. It seems like it can be fixed by changing aria-label= to aria-label$=. However, this is not from my branch anymore. How should we proceed? :)

@web-padawan
Copy link
Member Author

I'm assuming the 0.01% screenshot difference is not caused by this task.

Yes, this is a known problem specific to this component.

As for the failed tests, sorry for that, didn't realize I hadn't run on Firefox. It seems like it can be fixed by changing aria-label= to aria-label$=. However, this is not from my branch anymore. How should we proceed? :)

Thanks, fixed.

@web-padawan
Copy link
Member Author

The PR is green and IMO it is ready to go 👍 But it needs another review as I can't approve my own PR.

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants