Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dispose of Lit parts after changing a renderer [combo-box, virtual-list] #2325

Merged
merged 8 commits into from
Aug 12, 2021
Merged

fix: dispose of Lit parts after changing a renderer [combo-box, virtual-list] #2325

merged 8 commits into from
Aug 12, 2021

Conversation

tomivirkki
Copy link
Member

Fixes #2235

This is a follow-up for #2172 and addresses the same issues in <vaadin-combo-box> and <vaadin-virtual-list>.

@tomivirkki tomivirkki added no-polymer Removing Polymer from Vaadin public APIs target/21.0 labels Aug 12, 2021
@tomivirkki tomivirkki requested a review from vursen August 12, 2021 07:46
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 54042b7 into master Aug 12, 2021
@web-padawan web-padawan deleted the vl-cb-lit-parts branch August 12, 2021 10:32
@vaadin-bot
Copy link
Collaborator

Hi @tomivirkki , this commit cannot be picked to 21.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 54042b7
error: could not apply 54042b7... fix: dispose of Lit parts after changing a renderer (#2325)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

tomivirkki added a commit that referenced this pull request Aug 12, 2021
@tomivirkki
fix: dispose of Lit parts after changing a renderer (#2325)
b51d067
web-padawan pushed a commit that referenced this pull request Aug 12, 2021
@tomivirkki
fix: dispose of Lit parts after changing a renderer (#2325) (#2328)
d7aa65c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

@vursen vursen vursen approved these changes

Assignees
No one assigned
Labels
cherry-picked-21.0 need to pick manually 21.0 no-polymer Removing Polymer from Vaadin public APIs target/21.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[virtual-list] should clear rendered content when renderer changes
4 participants
@tomivirkki @vaadin-bot @vursen @web-padawan