Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a static "show" method to NotificationElement #2322

Merged
merged 5 commits into from
Aug 31, 2021

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Aug 11, 2021

Description

Enables use cases like

NotificationElement.show("The values have been stored in the database")

and

const undo = ...
NotificationElement.show(html`The values have been stored in the database <vaadin-button @click=${undo}>Undo</vaadin-button>`);

Fixes #914

Type of change

  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker sissbruecker merged commit abf0f69 into master Aug 31, 2021
@sissbruecker sissbruecker deleted the notification-show branch August 31, 2021 07:58
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[notification] Utility method for creation of the notification
4 participants