feat: add custom field with slotted label and helper #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/custom-field
branch
from
e4d1ac7
to
2708025
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
sissbruecker
reviewed
Aug 4, 2021
web-padawan
force-pushed
the
feat/custom-field
branch
from
e2f1578
to
a114e56
Compare
sissbruecker
approved these changes
Aug 5, 2021
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new implementation addresses #94 and #146 for
vaadin-custom-field.Note, this PR does not contain
customElements.define- that will be done separately in #2209Before that, we would need to update
vaadin-date-time-pickerto have its own base class - see #2205Fixes #2199
Type of change