test: cleanup and fix helper focus tests #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
alvarezguille
approved these changes
Jul 21, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 21, 2021
alvarezguille
added a commit
to vaadin/vaadin-checkbox
that referenced
this pull request
Jul 21, 2021
cherry pick of vaadin/web-components#2232 for v14 cherry pick of vaadin/web-components#2256 for v14 Fixes vaadin/flow-components#955
web-padawan
added a commit
that referenced
this pull request
Jul 21, 2021
Co-authored-by: Serhii Kulykov <[email protected]>
alvarezguille
added a commit
to vaadin/vaadin-text-field
that referenced
this pull request
Jul 21, 2021
also pick vaadin/web-components#2251 for v14 also pick vaadin/web-components#2256 for v14
This was referenced Jul 21, 2021
alvarezguille
added a commit
to vaadin/vaadin-checkbox
that referenced
this pull request
Jul 21, 2021
cherry pick of vaadin/web-components#2232 for v14 cherry pick of vaadin/web-components#2256 for v14 Fixes vaadin/flow-components#955
alvarezguille
added a commit
to vaadin/vaadin-text-field
that referenced
this pull request
Jul 21, 2021
* fix: do not focus the field on helper element click cherry pick of vaadin/web-components#2232 for v14 Fixes vaadin/flow-components#955 * chore: move helper tests with own fixture into own suite also pick vaadin/web-components#2251 for v14 also pick vaadin/web-components#2256 for v14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
focusedattribute.See #2255