Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[control-state-mixin] Rename focus-ring to focus-visible #2066

Open
abdonrd opened this issue Jun 18, 2020 · 1 comment
Open

[control-state-mixin] Rename focus-ring to focus-visible #2066

abdonrd opened this issue Jun 18, 2020 · 1 comment
Labels
requires new major This would be a breaking change vaadin-control-state-mixin

Comments

@abdonrd
Copy link
Contributor

abdonrd commented Jun 18, 2020

I know it would be a breaking change, but...

Would it make sense to rename focus-ring to focus-visible?
To be closer to the specification: https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible

https://github.com/vaadin/component-mixins/blob/c83bb8903ef1a84e011035b3ba30a99dfbc98e7f/packages/focus-visible-mixin/focus-visible-mixin.ts#L76-L82
@web-padawan
Copy link
Member

This was considered when working on vaadin/component-mixins#11 and is planned to be done in future.

The only reason to keep it would be consistency, as most of components are still Polymer based (and it's unlikely that we manage to finish the conversion any time soon).

@web-padawan web-padawan transferred this issue from vaadin/component-mixins May 28, 2021
@web-padawan web-padawan changed the title Rename focus-ring to focus-visible [control-state-mixin] Rename focus-ring to focus-visible May 28, 2021
@web-padawan web-padawan added requires new major This would be a breaking change next Future ideas labels May 28, 2021
tltv added a commit to vaadin/flow-components that referenced this issue Nov 9, 2021
@tltv
feat: allow theming individual menu items
eb46323 
Backported changes for Vaadin 14 from
vaadin/web-components#2066.

Depends on vaadin/vaadin-menu-bar#140.

Part of
#880.
alvarezguille pushed a commit to vaadin/flow-components that referenced this issue Nov 10, 2021
@tltv
feat: allow theming individual menu items (#2066) (#2323)
cbb662c 
This change enables theming individual menu bar items, for example to display one item as the primary item. As the menu bar uses the context menu to display submenus, most of the changes are in there.

* feat: allow theming individual menu items

Backported changes for Vaadin 14 from
vaadin/web-components#2066.

Depends on vaadin/vaadin-menu-bar#140.

Part of
#880.

* Bump vaadin-context-menu 4.6.0-alpha1 and vaadin-menu-bar  1.3.0-alpha1
@web-padawan web-padawan removed the next Future ideas label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
requires new major This would be a breaking change vaadin-control-state-mixin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abdonrd @web-padawan