fix: ensure has-value attribute is set on custom-value (#7885)

vaadin · Sep 30, 2024 · 9c57813 · 9c57813
1 parent ff28e96
commit 9c57813
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/packages/custom-field/src/vaadin-custom-field-mixin.js b/packages/custom-field/src/vaadin-custom-field-mixin.js
@@ -259,12 +259,12 @@ export const CustomFieldMixin = (superClass) =>
 
     /** @private */
     __valueChanged(value, oldValue) {
+      this.__toggleHasValue(value);
+
       if (this.__settingValue || !this.inputs) {
         return;
       }
 
-      this.__toggleHasValue(value);
-
       const parseFn = this.parseValue || defaultParseValue;
       const valuesArray = parseFn.apply(this, [value]);
       if (!valuesArray || valuesArray.length === 0) {

diff --git a/packages/custom-field/test/custom-field.common.js b/packages/custom-field/test/custom-field.common.js
@@ -68,6 +68,15 @@ describe('custom field', () => {
         expect(el.value).to.equal('1');
       });
     });
+
+    it('should set has-value when updating values', async () => {
+      customField.inputs.forEach((el) => {
+        el.value = '1';
+        fire(el, 'change');
+      });
+      await nextUpdate(customField);
+      expect(customField.hasAttribute('has-value')).to.be.true;
+    });
   });
 
   describe('aria-required', () => {