fix: delegate checked property to input

vaadin · Sep 19, 2021 · 7ede8a7 · 7ede8a7
1 parent 4e73052
commit 7ede8a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/field-base/src/checked-mixin.js b/packages/field-base/src/checked-mixin.js
@@ -25,8 +25,8 @@ const CheckedMixinImplementation = (superclass) =>
       };
     }
 
-    static get delegateAttrs() {
-      return [...super.delegateAttrs, 'checked'];
+    static get delegateProps() {
+      return [...super.delegateProps, 'checked'];
     }
 
     get _delegateStateTarget() {

diff --git a/packages/field-base/test/checked-mixin.test.js b/packages/field-base/test/checked-mixin.test.js
@@ -84,17 +84,17 @@ describe('checked-mixin', () => {
   });
 
   describe('delegation', () => {
-    describe('checked attribute', () => {
+    describe('checked property', () => {
       beforeEach(() => {
         element = fixtureSync(`<checked-mixin-element checked></checked-mixin-element>`);
         input = element.querySelector('[slot=input]');
       });
 
-      it('should delegate checked attribute to the input', () => {
-        expect(input.hasAttribute('checked')).to.be.true;
+      it('should delegate checked property to the input', () => {
+        expect(input.checked).to.be.true;
 
-        element.removeAttribute('checked');
-        expect(input.hasAttribute('checked')).to.be.false;
+        element.checked = false;
+        expect(input.checked).to.be.false;
       });
     });
   });