fix: do not close manual tooltip on target mousedown (#7746)

* fix: do not close manual tooltip on target mousedown * fix: make menu-bar tooltip close immediately on mousedown
vaadin · Sep 4, 2024 · 044b319 · 044b319
1 parent 101eaba
commit 044b319
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/packages/menu-bar/src/vaadin-menu-bar-mixin.js b/packages/menu-bar/src/vaadin-menu-bar-mixin.js
@@ -250,7 +250,7 @@ export const MenuBarMixin = (superClass) =>
       });
       this.addController(this._overflowController);
 
-      this.addEventListener('mousedown', () => this._hideTooltip());
+      this.addEventListener('mousedown', () => this._hideTooltip(true));
       this.addEventListener('mouseleave', () => this._hideTooltip());
 
       this._subMenu.addEventListener('item-selected', this.__onItemSelected.bind(this));

diff --git a/packages/tooltip/src/vaadin-tooltip-mixin.js b/packages/tooltip/src/vaadin-tooltip-mixin.js
@@ -653,6 +653,10 @@ export const TooltipMixin = (superClass) =>
 
     /** @private */
     __onMouseDown() {
+      if (this.manual) {
+        return;
+      }
+
       this._stateController.close(true);
     }
 

diff --git a/packages/tooltip/test/tooltip.common.js b/packages/tooltip/test/tooltip.common.js
@@ -799,6 +799,12 @@ describe('vaadin-tooltip', () => {
       expect(overlay.opened).to.be.true;
     });
 
+    it('should not close overlay on target mousedown', () => {
+      tooltip.opened = true;
+      mousedown(target);
+      expect(overlay.opened).to.be.true;
+    });
+
     it('should close overlay when opened is set to false', () => {
       tooltip.opened = true;