New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: bump test-runner, use fake timers #372

Merged

web-padawan merged 1 commit into master from test-fake-timers

Feb 8, 2021

Member

web-padawan commented Feb 2, 2021 •

edited

Loading

We should avoid using setTimeout and use Sinon fake timers instead.


          test: bump test-runner, use fake timers

f84d513

web-padawan force-pushed the test-fake-timers branch from dac903b to f84d513 Compare

February 3, 2021 07:27

web-padawan marked this pull request as ready for review

February 3, 2021 07:29

web-padawan requested a review from tomivirkki

February 3, 2021 07:29

tomivirkki approved these changes

View reviewed changes

web-padawan merged commit a01d44f into master

web-padawan deleted the test-fake-timers branch

February 8, 2021 09:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet