-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Polymer 3, add events type definitions #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
p3-events
branch
from
December 8, 2020 08:27
13b9391
to
43cded0
Compare
web-padawan
force-pushed
the
p3-events
branch
from
December 8, 2020 09:42
2ca2946
to
d90b44f
Compare
web-padawan
force-pushed
the
p3-events
branch
from
December 8, 2020 10:34
504e823
to
f55afbb
Compare
web-padawan
force-pushed
the
p3-events
branch
from
December 8, 2020 10:52
c36ac38
to
5435f6f
Compare
alvarezguille
previously requested changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo resources were converted an left, should they be removed @web-padawan
tomivirkki
approved these changes
Dec 11, 2020
tomivirkki
dismissed
alvarezguille’s stale review
December 11, 2020 07:56
Dismissing, as agreed yesterday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182