Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper text slot and API #219

Closed
juuso-vaadin opened this issue Apr 15, 2020 · 0 comments · Fixed by #227
Closed

Add helper text slot and API #219

juuso-vaadin opened this issue Apr 15, 2020 · 0 comments · Fixed by #227
Assignees
@DiegoCardoso
Labels
enhancement New feature or request

Comments

@juuso-vaadin
Copy link

Add slot for displaying text or component related to field.
Baseline implementation has been done for vaadin-text-field. See vaadin/vaadin-text-field#410
All implementations should follow the baseline implementation to achieve the same functionality.

Requirements

  • Add helper-text part which contains slot helper
  • Add observer to add has-helper attribute when helperText property is set
  • Add slotchange event handler to add has-helper attribute when content placed in helper slot
  • Add helper text to aria-describedby
  • Add observer for error message to add has-error-message attribute (used to hide helper in material theme when error message is set)

Visual specifications

image
@juuso-vaadin juuso-vaadin added the enhancement New feature or request label Apr 15, 2020
@DiegoCardoso DiegoCardoso self-assigned this Jun 1, 2020
DiegoCardoso added a commit that referenced this issue Jun 1, 2020
@DiegoCardoso
feat: add helperText API
bd4e05d 
- Add helperText API supporting string and slotted content
- Add demos
- Add unit and visual tests

Fix #219
@DiegoCardoso DiegoCardoso mentioned this issue Jun 1, 2020
Merged
DiegoCardoso added a commit that referenced this issue Jun 2, 2020
@DiegoCardoso
feat: add helperText slot and property API (#227)
f601bfc 
* feat: add helperText API

- Add helperText API supporting string and slotted content
- Add demos
- Add unit and visual tests

Fix #219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoCardoso DiegoCardoso

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add helperText slot and property API vaadin/vaadin-select
2 participants
@DiegoCardoso @juuso-vaadin