Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent exception in children.length when children is undefined #159

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

alvarezguille
Copy link
Member

On IE11, SVGElement#children returns undefined instead of an empty HTMLCollection
This was originally reported in PolymerElements/iron-overlay-behavior#283

On IE11, SVGElement#children returns undefined instead of an empty HTMLCollection
This was originally reported in PolymerElements/iron-overlay-behavior#283
Copy link
Contributor

@yuriy-fix yuriy-fix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add test for this case?

@web-padawan web-padawan merged commit 5bd96e9 into master Jul 17, 2019
@web-padawan web-padawan deleted the fix-length-of-undefined-svgelement branch July 17, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants