This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
Remove theme variants classes. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZheSun88
suggested changes
Jul 18, 2018
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: 0 of 1 LGTMs obtained
src/test/java/com/vaadin/flow/component/orderedlayout/tests/VerticalLayoutViewIT.java, line 44 at r1 (raw file):
vLayout.getAttribute("theme").contains("spacing")); Assert.assertTrue( "By default layout should contain spacing theme in 'theme' attribute",
should contain margin here.
Since both layouts do not extend the generated classes and already have an api that covers all the variants, it makes no sense to have variants classes here.
|
src/test/java/com/vaadin/flow/component/orderedlayout/tests/VerticalLayoutViewIT.java, line 44 at r1 (raw file): Previously, ZheSun88 (Sun Zhe) wrote…
Fixed. |
SomeoneToIgnore
force-pushed
the
kb/remove-variants-classes
branch
from
4b9c473 to
d622718
Compare
ZheSun88
approved these changes
Jul 18, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 0 of 1 LGTMs obtained
ZheSun88
approved these changes
Jul 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both layouts do not extend the generated classes and already have an api that covers all the variants,
it makes no sense to have variants classes here.
This change is