Update Grid to work with the new abstraction of HierarchicalArrayUpdater

[gilberto-torrezan]

Depends on vaadin/flow#4427

---

This change is 

[denis-anisimov]

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @denis-anisimov and @gilberto-torrezan)

---

src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java, line 143 at r1 (raw file):

return new TreeGridArrayUpdater()

Wouldn't it be better to extract this as a nested class ?

---

src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java, line 191 at r1 (raw file):

GridArrayUpdater arrayUpdater,

Doesn't it make sense to introduce ArrayUpdater class as a parameter type to DataCommunicatorBuilder so that this method accepts arrayUpdater with a parameter type so that there is no need to check its type and throw an ISE exception below ?

[gilberto-torrezan]

Reviewable status: 2 of 4 files reviewed, 4 unresolved discussions (waiting on @denis-anisimov and @vaadin-bot)

---

src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java, line 143 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…

return new TreeGridArrayUpdater()

Wouldn't it be better to extract this as a nested class ?

Done.

---

src/main/java/com/vaadin/flow/component/treegrid/TreeGrid.java, line 191 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…

GridArrayUpdater arrayUpdater,

Doesn't it make sense to introduce ArrayUpdater class as a parameter type to DataCommunicatorBuilder so that this method accepts arrayUpdater with a parameter type so that there is no need to check its type and throw an ISE exception below ?

Done.

[vaadin-bot]

SonarQube analysis reported 24 issues

• 1 critical
• 9 major
• 13 minor
• 1 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

1. Grid.java#L1650: Remove usage of generic wildcard type.
2. Grid.java#: This file has 1,201 lines, which is greater than 750 authorized. Split it into smaller files.
3. Grid.java#L1294: Call "Optional#isPresent()" before accessing the value.
4. Grid.java#L1295: Either log or rethrow this exception.
5. Grid.java#L1308: Either log or rethrow this exception.
6. Grid.java#L2065: Call "Optional#isPresent()" before accessing the value.
7. Grid.java#L2075: Call "Optional#isPresent()" before accessing the value.
8. TreeGrid.java#L438: Call "Optional#isPresent()" before accessing the value.
9. TreeGrid.java#L439: Either log or rethrow this exception.
10. TreeGrid.java#L453: Either log or rethrow this exception.

[denis-anisimov]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved