Prefer Flow development mode over localhost check #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After 5673bd3 `Vaadin.developmentMode` is always true for localhost even if flow is running in production mode.
web-padawan
approved these changes
Jun 27, 2019
alvarezguille
added a commit
to alvarezguille/vaadin-development-mode-detector
that referenced
this pull request
Jun 27, 2019
This reverts commit 4ff614f.
web-padawan
pushed a commit
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 5673bd3
Vaadin.developmentModeis always true for localhost even if flow is running in production mode.This change is