-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Polymer 3, add events type definitions #193
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ceacb3d
Remove demo and related dependencies
web-padawan 61e1ae5
Convert to Polymer 3 with magi-cli
web-padawan 1f423c8
Sort package.json, add module entry
web-padawan c5e4251
Commit typings to version control
web-padawan 919bd9b
Cleanup typings, extend HTMLElement
web-padawan 221f5da
Convert unit tests to web-test-runner
web-padawan ddae3cc
Replace dom-module with registerStyles
web-padawan 75e2666
Add web-dev-server and start script
web-padawan fa18b12
Fix API docs page, add prestart script
web-padawan c2dd643
Convert visual tests to hermione-esm
web-padawan 89d1a39
Use whitespace character entity
web-padawan 671c548
Add ESLint, Prettier, Stylelint and magi
web-padawan 3b6c067
Remove IE11 flexbox workarounds
web-padawan d1a2ed3
Cleanup Polymer imports
web-padawan ec78535
Update copyright headers
web-padawan 12f756d
Replace Travis with GitHub actions
web-padawan b28d03f
Update dependency versions
web-padawan 5389ee1
Update and cleanup README
web-padawan 75c1d2c
Restructure visual tests
web-padawan 71d3271
Add type definitions for custom events
web-padawan fe2e8e5
Update and move issue template
web-padawan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,15 @@ | ||
{ | ||
"extends": "vaadin", | ||
"extends": [ | ||
"eslint:recommended", | ||
"plugin:prettier/recommended" | ||
], | ||
"plugins": ["prettier"], | ||
"env": { | ||
"browser": true, | ||
"node": true, | ||
"es6": true | ||
}, | ||
"plugins": [ | ||
"html" | ||
], | ||
"globals": { | ||
"Polymer": false, | ||
"Vaadin": false | ||
"parserOptions": { | ||
"sourceType": "module", | ||
"ecmaVersion": 2018 | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
### Description | ||
<!-- Example: The `vaadin-checkbox` element does not get checked when clicked. --> | ||
|
||
### Live Demo | ||
<!-- Click "Remix This" and edit -- must be logged in to persist! --> | ||
https://glitch.com/edit/#!/vaadin-checkbox-issue | ||
<!-- ...or provide your own repro URL --> | ||
|
||
### Steps to Reproduce | ||
<!-- Example | ||
1. Put a `vaadin-text-field` element in the page. | ||
2. Type something into it. | ||
--> | ||
|
||
### Expected Results | ||
<!-- Example: Checkbox should be checked when clicked. --> | ||
|
||
### Actual Results | ||
<!-- Example: Checkbox is not checked when clicked. --> | ||
|
||
### Browsers Affected | ||
<!-- Check all that apply --> | ||
- [ ] Chrome | ||
- [ ] Firefox | ||
- [ ] Safari | ||
- [ ] iOS Safari | ||
- [ ] Android Chrome | ||
|
||
### Version | ||
<!-- | ||
`$ npm ls | grep @vaadin` will show the version of the components. | ||
--> | ||
- vaadin-checkbox: vX.X.X |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
name: sauce | ||
|
||
on: | ||
push: | ||
branches: | ||
- '**' | ||
tags-ignore: | ||
- '*.*' | ||
|
||
jobs: | ||
unit-tests: | ||
runs-on: ubuntu-latest | ||
if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')" | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12 | ||
|
||
- name: Install dependencies | ||
run: npm install | ||
|
||
- name: SauceLabs tests | ||
env: | ||
SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }} | ||
SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }} | ||
run: npm run test:sauce | ||
|
||
visual-tests: | ||
runs-on: ubuntu-latest | ||
if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')" | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12 | ||
|
||
- name: Install dependencies | ||
run: npm install | ||
|
||
- name: Visual tests | ||
env: | ||
SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }} | ||
SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }} | ||
run: npm run test:visual |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
name: tests | ||
|
||
on: [pull_request] | ||
|
||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12 | ||
|
||
- name: Install dependencies | ||
run: npm install | ||
|
||
- name: Check version | ||
run: npm run check-version | ||
|
||
- name: Lint JavaScript | ||
run: npm run lint:js | ||
|
||
- name: Lint CSS | ||
run: npm run lint:css | ||
|
||
- name: Lint typings | ||
run: npm run lint:types | ||
|
||
unit-tests: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12 | ||
|
||
- name: Install dependencies | ||
run: npm install | ||
|
||
- name: Unit tests | ||
run: npm test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
module.exports = { | ||
browsers: { | ||
chrome: { | ||
baseUrl: 'http://localhost:8080/test/visual/', | ||
screenshotsDir: (test) => { | ||
const folder = test.title.replace(/-(lumo|material)(-)?(rtl|ltr)?/, ''); | ||
return `test/visual/screens/${folder}`; | ||
}, | ||
desiredCapabilities: { | ||
browserName: 'chrome', | ||
version: '85.0', | ||
platform: 'Windows 10' | ||
} | ||
} | ||
}, | ||
plugins: { | ||
'hermione-esm': { | ||
port: 8080 | ||
}, | ||
'hermione-sauce': { | ||
verbose: false | ||
} | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"singleQuote": true, | ||
"printWidth": 120, | ||
"trailingComma": "none", | ||
"htmlWhitespaceSensitivity": "strict" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
{ | ||
"extends": "stylelint-config-vaadin" | ||
"extends": [ | ||
"stylelint-config-vaadin", | ||
"stylelint-config-prettier" | ||
] | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the issue reporting on this repo very Web Component -specific. Nowadays we also host the Flow component issues in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we need proper issue templates but that could be done separately.