fix: call click on checkbox Space key up (#239)

vaadin · Nov 8, 2023 · 7cc4752 · 7cc4752
1 parent ad4fbe6
commit 7cc4752
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/vaadin-checkbox.html b/src/vaadin-checkbox.html
@@ -265,12 +265,8 @@
           this.addEventListener('keyup', e => {
             if (this.__interactionsAllowed(e) && e.keyCode === 32) {
               e.preventDefault();
-              this._toggleChecked();
+              this.click();
               this.removeAttribute('active');
-
-              if (this.indeterminate) {
-                this.indeterminate = false;
-              }
             }
           });
         }

diff --git a/test/vaadin-checkbox_test.html b/test/vaadin-checkbox_test.html
@@ -228,6 +228,16 @@
         expect(vaadinCheckbox.getAttribute('aria-checked')).to.be.eql('true');
       });
 
+      it('should fire click event on space key press', () => {
+        const spy = sinon.spy();
+        vaadinCheckbox.addEventListener('click', spy);
+
+        MockInteractions.keyDownOn(vaadinCheckbox, 32);
+        MockInteractions.keyUpOn(vaadinCheckbox, 32);
+
+        expect(spy).to.be.calledOnce;
+      });
+
       it('should not be checked after space when initially checked is true and indeterminate is true', () => {
         vaadinCheckbox.checked = true;
         vaadinCheckbox.indeterminate = true;