Fix bug with slots

[rogozinds]

This change is 

[alvarezguille]

test/vaadin-board_slot_test.html, line 63 at r1 (raw file):

Elements insdie board that have slots are not children of board.

There is a typo, and it's a bit confusing IMHO

---

Comments from Reviewable

[DiegoCardoso]

Review status: 0 of 5 files reviewed at latest revision, 4 unresolved discussions, some commit checks broke.

---

test/board-element.html, line 8 at r1 (raw file):

:host {
 
}

It seems that this empty block is making build fails: block-no-empty and rule-empty-line-before rules.

---

test/outer.html, line 8 at r1 (raw file):

            :host {
                border-width: 3px;
                border-style:solid;

Build failing. Need to add a space after : because of declaration-colon-space-after rule.

---

test/vaadin-board_slot_test.html, line 58 at r1 (raw file):

            var child = children[i];

            assert.isAtLeast(child.getAttribute("style").indexOf("flex-basis: 25%"), 0,

This test is failing on my machine because flex-basis is 50%. Would it be because viewport is not large enough?

---

Comments from Reviewable

[rogozinds]

Review status: 0 of 5 files reviewed at latest revision, 4 unresolved discussions.

---

test/outer.html, line 8 at r1 (raw file):

Previously, DiegoCardoso (Diego Cardoso) wrote…

Build failing. Need to add a space after : because of declaration-colon-space-after rule.

Done.

---

test/vaadin-board_slot_test.html, line 63 at r1 (raw file):

Previously, alvarezguille (Guille) wrote…

Elements insdie board that have slots are not children of board.

There is a typo, and it's a bit confusing IMHO

Done.

---

Comments from Reviewable

[rogozinds]

Review status: 0 of 5 files reviewed at latest revision, 4 unresolved discussions.

---

test/board-element.html, line 8 at r1 (raw file):

Previously, DiegoCardoso (Diego Cardoso) wrote…

:host {
 
}

It seems that this empty block is making build fails: block-no-empty and rule-empty-line-before rules.

Done.

---

Comments from Reviewable

[rogozinds]

Review status: 0 of 5 files reviewed at latest revision, 4 unresolved discussions.

---

test/vaadin-board_slot_test.html, line 58 at r1 (raw file):

Previously, DiegoCardoso (Diego Cardoso) wrote…

This test is failing on my machine because flex-basis is 50%. Would it be because viewport is not large enough?

Added fixed size of the board.

---

Comments from Reviewable

[rogozinds]

Review status: 0 of 5 files reviewed at latest revision, 2 unresolved discussions.

---

test/vaadin-board_slot_test.html, line 58 at r1 (raw file):

Previously, rogozinds (rogozinds) wrote…

Added fixed size of the board.

Done.

---

Comments from Reviewable

[alvarezguille]

Reviewed 4 of 5 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[alvarezguille]

---

Comments from Reviewable

[DiegoCardoso]

---

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

---

Comments from Reviewable