Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move CI builds from travis-ci.org to GitHub actions #137

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

vlukashov
Copy link
Contributor

@vlukashov vlukashov commented Jul 5, 2021

Description

The CI builds cover the following use cases:

  • run a full set of automated code checks for each PR (see unit-tests.yml in .github/workflows/)
    • when a new PR is open (for any branch having this workflow .yml file)
    • when an open PR gets a new commit (including a force push)
  • do not run automated checks if the commit title includes skip ci
    The automated checks are skipped only for that one commit which has skip ci. For consequent commits that do not have skip ci the checks are executed normally.

The full set of automated tests includes both unit and visual tests:

  • Unit tests are executed with the Polymer 2 source code, and also with the Polymer 3 source code after running the P2-to-P3 conversion script.
    • The unit tests with the Polymer 3 source code are executed in a set of different browsers / platforms (via SauceLabs).
    • The unit tests with the Polymer 2 source code are executed in a few browsers running headlessly in the CI agent.
  • NO visual tests (unlike many other Vaadin web components, vaadin-board does not have visual tests).

Related to: https://github.com/vaadin/components-team-tasks/issues/586

Type of change

  • Bugfix
  • Feature
  • Internal change

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Viktor Lukashov added 4 commits July 5, 2021 16:46
The CI builds cover the following use cases:
 - run a full set of automated code checks for each PR (see the `Full QA` workflow in `.github/workflows/full-qa.yml`)
   - when a new PR is open (for any target branch)
   - when an open PR gets a new commit (including a force push)
 - do not run automated checks if the commit title includes `skip ci`
   The automated checks are skipped only for that one commit which has `skip ci`. For consequent commits that do not have `skip ci` the checks are executed normally.

The full set of automated tests includes both unit and visual tests:
 - Unit tests are executed with the Polymer 2 source code, and also with the Polymer 3 source code after running the P2-to-P3 conversion script.
   - The unit tests with the Polymer 3 source code are executed in a set of different browsers / platforms (via SauceLabs).
   - The unit tests with the Polymer 2 source code are executed in a few browsers running headlessly in the CI agent.
 - Visual tests are executed with the Polymer 2 source code in Chrome and Firefox (via SauceLabs).

Related to: https://github.com/vaadin/components-team-tasks/issues/586
@web-padawan web-padawan merged commit a017878 into 2.2 Jul 6, 2021
@web-padawan web-padawan deleted the vl/move-from-travis-to-gh-actions branch July 6, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants