fix: disable chrome search engine selection #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
commented
Aug 23, 2024
| options.addArguments("--test-type "); | ||
| // Disable search engine choice screen | ||
| options.addArguments("--disable-search-engine-choice-screen"); |
There was a problem hiding this comment.
I'm not sure if the search engine selection should be disabled for other types of tests too.
However for local tests it's problematic because it seems that you can't customize the Chrome options in your test code - the method here ignores just ignores the capabilities passed in, so even if you would try to add this argument in your test setup it doesn't work. For example, I tried to configure the argument in flow-components here, but the capabilities created from that are ignored.
Artur-
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1817