feat: rework "containing" selectors via addition of remaining attribute operators #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed name of "containing" attribute selector methods from "xContains" to "xContainsToken". Added true "containing" attribute selector methods.
mcollovati
requested changes
Apr 17, 2024
vaadin-testbench-shared/src/main/java/com/vaadin/testbench/ElementQuery.java
Show resolved
Hide resolved
vaadin-testbench-shared/src/main/java/com/vaadin/testbench/ElementQuery.java
Outdated
Show resolved
Hide resolved
vaadin-testbench-shared/src/main/java/com/vaadin/testbench/ElementQuery.java
Outdated
Show resolved
Hide resolved
vaadin-testbench-shared/src/main/java/com/vaadin/testbench/ElementQuery.java
Outdated
Show resolved
Hide resolved
vaadin-testbench-shared/src/main/java/com/vaadin/testbench/ElementQuery.java
Outdated
Show resolved
Hide resolved
vaadin-testbench-shared/src/main/java/com/vaadin/testbench/ElementQuery.java
Outdated
Show resolved
Hide resolved
vaadin-testbench-shared/src/main/java/com/vaadin/testbench/ElementQuery.java
Outdated
Show resolved
Hide resolved
vaadin-testbench-shared/src/main/java/com/vaadin/testbench/ElementQuery.java
Outdated
Show resolved
Hide resolved
Deprecated for removal obsolete AttributeMatch constructor. Fixed various Javadoc comments.
…Query-withAttributeContaining-operator # Conflicts: # vaadin-testbench-core-junit5/src/test/java/com/vaadin/testbench/ElementQueryTest.java # vaadin-testbench-core/src/test/java/com/vaadin/testbench/ElementQueryTest.java # vaadin-testbench-shared/src/main/java/com/vaadin/testbench/ElementQuery.java
mcollovati
requested changes
Apr 22, 2024
vaadin-testbench-shared/src/main/java/com/vaadin/testbench/ElementQuery.java
Outdated
Show resolved
Hide resolved
mcollovati
approved these changes
Apr 24, 2024
mcollovati
deleted the
feature/#1554-ElementQuery-withAttributeContaining-operator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored name of "xContaining" attribute selector methods to "xContainingToken".
Added true "xContaining" attribute selector methods that match on substrings instead of on tokens.
Added remaining attribute matching operators and a corresponding selector method to utilize them. Refactored existing attribute-based selector methods to use this method.
Fixes #1554
Type of change
Checklist
Additional for
Featuretype of change