Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GridTester.sortByColumn(): consider the value of MultiSortPriority as well. #1700

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

mvysny
Copy link
Member

@mvysny mvysny commented Nov 14, 2023

Description

GridTester.sortByColumn(): consider the value of MultiSortPriority as well.

Fixes #1695

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2023

CLA assistant check
All committers have signed the CLA.

@mvysny
Copy link
Member Author

mvysny commented Nov 15, 2023

@mcollovati thank you for the approval 🙏 @caalador could you please merge? I'm not authorized to merge this PR.

@mcollovati mcollovati merged commit ca484b0 into main Nov 15, 2023
2 checks passed
@mcollovati mcollovati deleted the fix/1695 branch November 15, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GridTester#doSort sets wrong sort order for grid with MultiSortPriority#APPEND mode
3 participants