Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tester for SideNav component #1691

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat: add tester for SideNav component #1691

merged 2 commits into from
Oct 26, 2023

Conversation

mcollovati
Copy link
Contributor

Also refactors ComponentTester to expose some utility method to subclasses.

Part of #1635

@mcollovati
feat: add tester for SideNav component
2ea01e8 
Also refactors ComponentTester to expose some utility method to subclasses.

Part of #1635
@mcollovati
Copy link
Contributor Author

The tester can potentially be further improved by providing methods to access items by index (as done in MenuBarTester) and to get single items instance.
We can also consider if it is worth it adding a tester for SideNavItem.

@mcollovati mcollovati merged commit 52eff3d into main Oct 26, 2023
2 checks passed
@mcollovati mcollovati deleted the issues/1635_side_nave_tester branch October 26, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czp13 czp13 czp13 approved these changes

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Vaadin Flow ongoing work (Vaadin 10+)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcollovati @caalador @czp13