Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add missing NativeLabelTester #1654

Merged
merged 2 commits into from
Aug 29, 2023
Merged

chore: Add missing NativeLabelTester #1654

merged 2 commits into from
Aug 29, 2023

Conversation

TatuLund
Copy link
Contributor

In Vaadin 24.1 NativeLabel replaced Label

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mcollovati
Copy link
Contributor

The current testbench version is compatible with Vaadin 24.0, that however does not contain NativeLabel (from 24.1)

@mshabarov mshabarov mentioned this pull request Aug 14, 2023
Merged
@mshabarov
Copy link
Contributor

This now fails with Check contributor CI rights.
@ZheSun88 do you know how to fix it?

@mshabarov mshabarov merged commit 6d54865 into vaadin:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

@mcollovati mcollovati Awaiting requested review from mcollovati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TatuLund @CLAassistant @mcollovati @mshabarov