Upgrade selenium version to 4.16.1 (8.2) (#1711)

* Upgrade selenium version to 4.16.0 (8.2) * Update pom.xml * remove selenium-http-jdk-client dependency * pick the headless update from 4.12 to 4.13 version update --------- Co-authored-by: Artur <[email protected]>
vaadin · Dec 14, 2023 · af2aca8 · af2aca8
1 parent 318a604
commit af2aca8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/pom.xml b/pom.xml
@@ -33,7 +33,7 @@
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <Implementation-Version>${project.version}</Implementation-Version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <selenium.version>4.8.3</selenium.version>
+        <selenium.version>4.16.1</selenium.version>
         <maven.compiler.source>11</maven.compiler.source>
         <maven.compiler.target>11</maven.compiler.target>
         <license.checker.version>1.12.3</license.checker.version>

diff --git a/vaadin-testbench-core/pom.xml b/vaadin-testbench-core/pom.xml
@@ -157,10 +157,6 @@
             <groupId>org.seleniumhq.selenium</groupId>
             <artifactId>selenium-java</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.seleniumhq.selenium</groupId>
-            <artifactId>selenium-http-jdk-client</artifactId>
-        </dependency>
         <dependency>
             <groupId>org.seleniumhq.selenium</groupId>
             <artifactId>selenium-devtools-v115</artifactId>

diff --git a/vaadin-testbench-core/src/main/java/com/vaadin/testbench/parallel/setup/LocalDriver.java b/vaadin-testbench-core/src/main/java/com/vaadin/testbench/parallel/setup/LocalDriver.java
@@ -67,7 +67,9 @@ static public WebDriver createDriver(
                 FirefoxProfile profile = new FirefoxProfile(profileDir);
                 options.setProfile(profile);
             }
-            options.setHeadless(Parameters.isHeadless());
+            if (Parameters.isHeadless()) {
+                options.addArguments("-headless");
+            }
             driver = new FirefoxDriver(options);
         } else if (BrowserUtil.isChrome(desiredCapabilities)) {
             // Tells chrome not to show warning
@@ -76,7 +78,9 @@ static public WebDriver createDriver(
             // #14319
             ChromeOptions options = new ChromeOptions();
             options.addArguments("--test-type ");
-            options.setHeadless(Parameters.isHeadless());
+             if (Parameters.isHeadless()) {
+                options.addArguments("--headless=new");
+            }
             driver = new ChromeDriver(options);
         } else if (BrowserUtil.isSafari(desiredCapabilities)) {
             driver = new SafariDriver();