-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expose Spring executor for Vaadin dev mode #692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonarQube analysis reported 14 issues Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
caalador
approved these changes
Dec 2, 2020
denis-anisimov
pushed a commit
that referenced
this pull request
Dec 3, 2020
Part of #691 # Conflicts: # vaadin-spring/src/test/java/com/vaadin/flow/spring/VaadinServletContextInitializerTest.java
denis-anisimov
pushed a commit
that referenced
this pull request
Dec 3, 2020
Part of #691 # Conflicts: # vaadin-spring/src/test/java/com/vaadin/flow/spring/VaadinServletContextInitializerTest.java
denis-anisimov
pushed a commit
that referenced
this pull request
Dec 3, 2020
Part of #691 # Conflicts: # vaadin-spring/src/test/java/com/vaadin/flow/spring/VaadinServletContextInitializerTest.java
denis-anisimov
pushed a commit
that referenced
this pull request
Dec 4, 2020
Part of #691 # Conflicts: # vaadin-spring/src/test/java/com/vaadin/flow/spring/VaadinServletContextInitializerTest.java
denis-anisimov
pushed a commit
that referenced
this pull request
Dec 4, 2020
Part of #691 # Conflicts: # vaadin-spring/src/test/java/com/vaadin/flow/spring/VaadinServletContextInitializerTest.java
caalador
pushed a commit
that referenced
this pull request
Dec 14, 2020
Part of #691 # Conflicts: # vaadin-spring/src/test/java/com/vaadin/flow/spring/VaadinServletContextInitializerTest.java
manolo
pushed a commit
to vaadin/flow
that referenced
this pull request
Feb 8, 2022
vaadin/spring#692 Part ofvaadin/spring#691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #691