Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add RouterLayout as bean classes #85

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

mcollovati
Copy link
Contributor

Description

Currently RouterLayout implementations are ignored by CDI in Quarkus This change specify RouterLayout implementors as additional bean classes to be analyzed during bean discovery.

Fixes #75

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Currently RouterLayout implementations are ignored by CDI in Quarkus
This change specify RouterLayout implementors as additional bean classes
to be analyzed during bean discovery.

Fixes #75
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mshabarov mshabarov self-requested a review September 15, 2022 07:08
@mshabarov mshabarov merged commit 8b8e795 into master Sep 15, 2022
@mshabarov mshabarov deleted the issue/75_router_layout_beans branch September 15, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDI not working in parent layouts
2 participants