fix: index optional dependencies (#172) (CP: 2.0) #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development (e.g. vaadin-dev-server) and optional (e.g. flow-react) dependencies must not be present in the Vaadin platform indexed, to prevent NoClassDefFound errors at runtime, for example when running a production build with dev-server excluded. This change adds a build step to index optional dependencies only if they are present in the project configuration. Part of #158
mshabarov
previously approved these changes
Sep 12, 2024
Branch 2.0 of the add-on supports Quarkus 3.2 and 3.8.
mshabarov
approved these changes
Sep 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development (e.g. vaadin-dev-server) and optional (e.g. flow-react) dependencies must not be present in the Vaadin platform indexed, to prevent NoClassDefFound errors at runtime, for example when running a production build with dev-server excluded.
This change adds a build step to index optional dependencies only if they are present in the project configuration.
Part of #158