Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization timeout configurable property #99

Merged
merged 9 commits into from
Jan 11, 2024

Conversation

tamasmak
Copy link
Contributor

@tamasmak tamasmak commented Jan 5, 2024

  • Makes serialization timeout configurable to wait for the serialization to be completed (default timeout has been increased to 30s)
    • If using SpringBoot then a timeout property in SerializationProperties is available to set the timeout
    • If not using SpringBoot then a vaadin.serialization.timeout system property is available to set the timeout
  • Updates log messages to make it more clear when a serialization timeout happens and when a serialization job is finished
  • Adds check for serialization timeout when updating the result messages in Job::complete to avoid ConcurrentModificationException because in case of timeout the serialization could still run and updating the messages too

Closes #94 and #97

@tamasmak tamasmak self-assigned this Jan 5, 2024
@tamasmak tamasmak marked this pull request as ready for review January 10, 2024 07:55
Copy link
Contributor

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for potential minor changes, but other than that LGTM

@heruan heruan merged commit fa02c17 into main Jan 11, 2024
2 checks passed
@heruan heruan deleted the feat/configurable-timeout branch January 11, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes Kit - Session Replication Debug Tool - Configurable Timeout
3 participants